qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

Quantum machines #722

Closed jordivallsq closed 3 months ago

jordivallsq commented 3 months ago

There was a rounding error involving the signs <= and >= in the compilation of the QUA program's for loops, the error caused results not to generate showcasing a bug.

The signs have been replaced by < and > and the stop value has been replaced by stop +- step/2.

This solution has been checked using the experiment located in qililab-portfolio/experiments/qprogram/flux_vs_flux_pulse.ipynb, if the experiment is executed with a gain step number greater than 9 without this hotfix the results will crash and not return anything.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.19%. Comparing base (92e1990) to head (35c7477).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #722 +/- ## ======================================= Coverage 96.19% 96.19% ======================================= Files 275 275 Lines 9087 9087 ======================================= Hits 8741 8741 Misses 346 346 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/722/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/722/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.19% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jordivallsq commented 3 months ago

@paulqili tested and approved the bug fix with his computer