search

qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

Qhc 466 bug wait instruction is not compiled proprely on qprogam for #727

Closed jordivallsq closed 3 months ago

jordivallsq commented 3 months ago

Following the description on the QM reference https://docs.quantum-machines.co/1.1.6/qm-qua-sdk/docs/API_references/qua/dsl_main/#qm.qua._dsl.wait, the used by the QM compiler now is divided by 4 which returns the correct amount of ns waited (before it was multiplied by 4)

linear[bot] commented 3 months ago

QHC-466 [BUG] Wait instruction is not compiled proprely on Qprogam for QM

jordivallsq commented 3 months ago

The wait correctly now works both for fixed waits and also dynamical waits.

Here is an image of a T1 experiment where the waits change. image

As a reference, the second wait (dynamical) should be 500 ns (the amount set by code), if the bug persisted it should had been 2000 ns image

This experiment has been done in collaboration with Oscar

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.24%. Comparing base (e62d811) to head (0bce62d). Report is 37 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #727 +/- ## ======================================= Coverage 96.24% 96.24% ======================================= Files 275 275 Lines 9087 9088 +1 ======================================= + Hits 8746 8747 +1 Misses 341 341 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/727/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/727/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.24% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.