Closed fedonman closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.24%. Comparing base (
27349fa
) to head (c4e2dae
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.
Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.
I also think an example with the yml file for calibration would be ideal to have here.
Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.
I also think an example with the yml file for calibration would be ideal to have here.
I couldn't find any place to just throw a random yaml file, so I added the contents of it in the changelog entry.
Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.
I also think an example with the yml file for calibration would be ideal to have here.
I couldn't find any place to just throw a random yaml file, so I added the contents of it in the changelog entry.
Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.
I also think an example with the yml file for calibration would be ideal to have here.
I couldn't find any place to just throw a random yaml file, so I added the contents of it in the changelog entry.
Changelog is good, ideal if also goes into QProgram documentation.
B pvl im za
On Wed, 29 May 2024, 12:16 jjmartinezQT, @.***> wrote:
Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.
I also think an example with the yml file for calibration would be ideal to have here.
— Reply to this email directly, view it on GitHub https://github.com/qilimanjaro-tech/qililab/pull/729#issuecomment-2137058964, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2IPDOBVWZZIXVBBA5SIJDZEWTIJAVCNFSM6AAAAABILEFNFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXGA2TQOJWGQ . You are receiving this because you authored the thread.Message ID: @.***>
B pvl im za
possesed by @fabiques spirit?
Fabio mentioned to not merge already the PR because they want to see the demo and the Yaml structure before and they will probably have feedback. So if it is not necessary can we wait to merge this after some hardware tests/feedback? If you think we have to publish this we can always publish and then apply some changes (as it is not overlaping with what we already have), from my side this is also ok.
Calibration
class to manage calibrated operations for QProgram, including methods to add (add_operation
), retrieve (get_operation
), save (dump
), and load (load
) calibration data.qililab.yaml
namespace that exports a singleYAML
instance for common use throughout qililab. Classes can be registered to this instance with the@yaml.register_class
decorator.QProgram.with_bus_mapping
method to remap buses within the QProgram.QProgram.with_calibration
method to apply calibration to operations within the QProgram.Platform.execute_qprogram
method to accept a calibration instance.Note: I implemented the calibrated operations only for QProgram's
play
instruction. If we like this implementation it can easily be extended for other instructions as well, e.g.measure
.