qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

[QHC-374] Add Calibration for waveforms, Refactor parts of QProgram #729

Closed fedonman closed 2 months ago

fedonman commented 3 months ago

Note: I implemented the calibrated operations only for QProgram's play instruction. If we like this implementation it can easily be extended for other instructions as well, e.g. measure.

linear[bot] commented 3 months ago

QHC-374 Create way of loading calibrated pulses in qprogram

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.24%. Comparing base (27349fa) to head (c4e2dae).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #729 +/- ## ========================================== + Coverage 96.18% 96.24% +0.05% ========================================== Files 276 278 +2 Lines 8889 9016 +127 ========================================== + Hits 8550 8677 +127 Misses 339 339 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/729/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/729/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.24% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jordivallsq commented 3 months ago

Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.

jjmartinezQT commented 3 months ago

Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.

I also think an example with the yml file for calibration would be ideal to have here.

fedonman commented 3 months ago

Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.

I also think an example with the yml file for calibration would be ideal to have here.

I couldn't find any place to just throw a random yaml file, so I added the contents of it in the changelog entry.

jjmartinezQT commented 3 months ago

Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.

I also think an example with the yml file for calibration would be ideal to have here.

I couldn't find any place to just throw a random yaml file, so I added the contents of it in the changelog entry.

Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.

I also think an example with the yml file for calibration would be ideal to have here.

I couldn't find any place to just throw a random yaml file, so I added the contents of it in the changelog entry.

Changelog is good, ideal if also goes into QProgram documentation.

fedonman commented 3 months ago

B pvl im za

On Wed, 29 May 2024, 12:16 jjmartinezQT, @.***> wrote:

Apart from some questions I couldn't find any issue with the code It is really well done and the changes on existing features such as bus mapping look good. In the demo I am interested in the structure of the yml file (as I cannot fully see how it will look like), after having clear how it should look like exactly I can assist with the validation.

I also think an example with the yml file for calibration would be ideal to have here.

— Reply to this email directly, view it on GitHub https://github.com/qilimanjaro-tech/qililab/pull/729#issuecomment-2137058964, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2IPDOBVWZZIXVBBA5SIJDZEWTIJAVCNFSM6AAAAABILEFNFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXGA2TQOJWGQ . You are receiving this because you authored the thread.Message ID: @.***>

jjmartinezQT commented 3 months ago

B pvl im za

possesed by @fabiques spirit?

jordivallsq commented 2 months ago

Fabio mentioned to not merge already the PR because they want to see the demo and the Yaml structure before and they will probably have feedback. So if it is not necessary can we wait to merge this after some hardware tests/feedback? If you think we have to publish this we can always publish and then apply some changes (as it is not overlaping with what we already have), from my side this is also ok.