search

qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

[QHC-532] Serialize with YAML #737

Closed fedonman closed 2 months ago

linear[bot] commented 2 months ago

QHC-532 Serialize QProgram with ruamel.yaml [DEMO]

github-actions[bot] commented 2 months ago

Hello. You may have forgotten to update the changelog! Please edit changelog-dev.md with:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.40260% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.27%. Comparing base (0b9cf45) to head (0b7ccd4).

Files Patch % Lines
src/qililab/utils/serialization.py 91.66% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #737 +/- ## ======================================== Coverage 96.26% 96.27% ======================================== Files 278 279 +1 Lines 9086 9217 +131 ======================================== + Hits 8747 8874 +127 - Misses 339 343 +4 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/737/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/737/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.27% <97.40%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jordivallsq commented 2 months ago

why the class Operation in qililab\src\qililab\qprogram\operations\operation.py is the only one not included in the yaml serialization?

jordivallsq commented 2 months ago

Great job Vyron, I added some comments and questions and once those are solved we can merge

fedonman commented 2 months ago

why the class Operation in qililab\src\qililab\qprogram\operations\operation.py is the only one not included in the yaml serialization?

Abstract classes don't need to be registered.