search

qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

[QHC-264] Add `time_of_flight` to Qblox and use it for compiling `measure` operation #738

Closed fedonman closed 2 months ago

linear[bot] commented 2 months ago

QHC-264 Add `time_of_flight` property to buses and use it for Qblox's `measure`

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.28%. Comparing base (209ca29) to head (58d4f9c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #738 +/- ## ======================================= Coverage 96.27% 96.28% ======================================= Files 279 279 Lines 9217 9231 +14 ======================================= + Hits 8874 8888 +14 Misses 343 343 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/738/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/738/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.28% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jordivallsq commented 2 months ago

Great job with the addition of TOF!!! I left a couple of comments.

Probably you already have this in your scope but is it planned to add the time of flight for QM in a similar way? I suppose the only thing that needs to change is the quantum_machines_compiler (and other minor adjustments) as the basis is already set.

Additionally in QM we also have smearing (among other different variables on measure), could we also add these on your methodology? I am actually asking because it is QM exclusive so I don't know if (or where) we can do the same as with the time of flight.

fedonman commented 2 months ago

Great job with the addition of TOF!!! I left a couple of comments.

Probably you already have this in your scope but is it planned to add the time of flight for QM in a similar way? I suppose the only thing that needs to change is the quantum_machines_compiler (and other minor adjustments) as the basis is already set.

Additionally in QM we also have smearing (among other different variables on measure), could we also add these on your methodology? I am actually asking because it is QM exclusive so I don't know if (or where) we can do the same as with the time of flight.

Time of flight is already implemented in Quantum Machines, natively by them. We already provide the parameter in the runcard.

Smearing is a QM-specific parameter, I don't know if it makes sense or if it is even possible to implement something similar for Qblox.

jordivallsq commented 2 months ago

@jordivallsq Smearing is implemented for QM, you provide the parameter in the instrument's settings in the runcard.