qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

[QHC-548] Fix QProgram's bus mapping bug #740

Closed fedonman closed 2 months ago

linear[bot] commented 2 months ago

QHC-548 Fix QProgram's bus mapping if mapping to self (X -> X)

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.28%. Comparing base (5047ecc) to head (9bc8a21).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #740 +/- ## ======================================= Coverage 96.28% 96.28% ======================================= Files 278 278 Lines 9119 9122 +3 ======================================= + Hits 8780 8783 +3 Misses 339 339 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/740/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/740/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.28% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fedonman commented 2 months ago

The changes are good, thank you!

One question though, this non_existant_mapping_qp test what is showing? What means putting "non_existant" in the bus mapping?

I wanted to make sure that if you map a bus that doesn't exist in the qprogram, you won't get an error.