qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

[QHC-547] Add Align gate to transpiler #741

Closed IsaacLA12 closed 2 months ago

IsaacLA12 commented 2 months ago

We are adding the translation of the Qibo gate Align to a Qililab Wait

Note there is no strictly 'wait' gait in Qibo, you can see in the documentation (not very well explained 🤠 ) that this gate acts kinda like a barrier and also adds a wait at the end.

linear[bot] commented 2 months ago

QHC-547 Add gate decomposition of qibo.wait gate

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.28%. Comparing base (fc46345) to head (5d43755).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #741 +/- ## ======================================= Coverage 96.28% 96.28% ======================================= Files 278 278 Lines 9122 9123 +1 ======================================= + Hits 8783 8784 +1 Misses 339 339 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/741/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/741/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.28% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

visagim commented 2 months ago

Add the Wait gate to the list of native gates at https://github.com/qilimanjaro-tech/qililab/blob/e143087c3c04fa359bb6d460c5d5b381278abb8f/src/qililab/circuit_transpiler/gate_decompositions.py#L104 pls

IsaacLA12 commented 2 months ago

Sure!