search

qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

Implemented an aditional error on IQPair #745

Closed jordivallsq closed 1 month ago

jordivallsq commented 1 month ago

Found a bug on qilitools where an IQPair contained 2 other IQPair (this was a mistake). The error was difficult to trace back because the class IQPair accepted other options beside Waveform without complaining. I added an exception so if you create an IQPair with something other than a Waveform it throws a clear error.

linear[bot] commented 1 month ago

QHC-584 [BUG] IQPairs do not reproduce the envelope

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.28%. Comparing base (6bf3e96) to head (20404c6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #745 +/- ## ======================================= Coverage 96.28% 96.28% ======================================= Files 278 278 Lines 9123 9125 +2 ======================================= + Hits 8784 8786 +2 Misses 339 339 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/745/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `96.28% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.