qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
29 stars 2 forks source link

Qhc 588 bug `get_parameter` does not work with QM platform #751

Closed jordivallsq closed 4 weeks ago

jordivallsq commented 1 month ago

Fixed the bug on QM that crashed the get_parameter function and changed the QM get_parameter to work without connection to the instrument

linear[bot] commented 1 month ago

QHC-588 [BUG] Get_parameter does not work with QM platform

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.96%. Comparing base (4975900) to head (fe15bc8).

Files Patch % Lines
src/qililab/system_control/system_control.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #751 +/- ## ======================================= Coverage 94.96% 94.96% ======================================= Files 263 263 Lines 8596 8628 +32 ======================================= + Hits 8163 8194 +31 - Misses 433 434 +1 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/751/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `94.96% <98.43%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GuillermoAbadLopez commented 1 month ago

Did this commit: https://github.com/qilimanjaro-tech/qililab/pull/751/commits/916d5d7bb22cdb9f2ebbbbd7a799637550c511d1, adding:

GuillermoAbadLopez commented 1 month ago

@jordivallsq appart than the still open comment, this one I think its ready to go!

Check the last changes, when you can, please! 🙏 (tomorrow I'll address/resolve my still opened silly comments 👍 )

jordivallsq commented 4 weeks ago

Added @GuillermoAbadLopez changes on set_parameter