Closed jordivallsq closed 4 weeks ago
Attention: Patch coverage is 98.43750%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 94.96%. Comparing base (
4975900
) to head (fe15bc8
).
Files | Patch % | Lines |
---|---|---|
src/qililab/system_control/system_control.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Did this commit: https://github.com/qilimanjaro-tech/qililab/pull/751/commits/916d5d7bb22cdb9f2ebbbbd7a799637550c511d1, adding:
_config_exists
bool/flag attribute, taht turns True when we initial_setup
and the _config
is created_config
in the get_parameter()
, but only where its supposed to happen, in the initial_setup
, creating a temporary dictionary if it doesn't exist beforehand👍 (This code can be changed by getting parameters from the settings
instead)@jordivallsq appart than the still open comment, this one I think its ready to go!
Check the last changes, when you can, please! 🙏 (tomorrow I'll address/resolve my still opened silly comments 👍 )
Added @GuillermoAbadLopez changes on set_parameter
Fixed the bug on QM that crashed the get_parameter function and changed the QM get_parameter to work without connection to the instrument