Closed GuillermoAbadLopez closed 4 weeks ago
Be aware, that this might be problematic, since we have the self._config
dictionary, that duplicate the information of the runtime Runcard
/Settings
, and we would need to update both 😬:
https://qilimanjaro.slack.com/archives/C06R0KWN58W/p1721232248001349
I guess in the set_parameter
, you would need to do:
if "_config" not in dir(self):
self._config = self.settings.to_qua_config()
# Or with just a: `self._config = self.settings.to_qua_config()`, if we decide the setting to rule!
# Then all the code that goes along, changing stuff in _config
# Check that everything that is being changed in runtime `Settings`, changes in `_config`,
# or do another in the end: self._config = self.settings.to_qua_config()
Attention: Patch coverage is 96.55172%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 94.96%. Comparing base (
c70813e
) to head (57f958d
).
Files | Patch % | Lines |
---|---|---|
src/qililab/system_control/system_control.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Also, for merging this PR, we still need to check that a posterior initial_setup
,
will then set the parameters that have been changed locally
initial_setup
(problem with _qm
and _qmm
initialization)[x] Create test to check that this is indeed the case!
Update, answer:
initial_setup
and turn_on
sets stuff in the class_qmm
and _qm
creation!
(they are kind of mixed -> New possible problem?)
We need to be able to set a parameter, without connection:
We need to do the same we did for
Qblox
(here: https://github.com/qilimanjaro-tech/qililab/pull/647), so that when we set a parameter without connection, it changes the execution-timeRuncard
locally, so when youconnect()
andinitial_setup()
, it gets set up on the actual physical instruments, as the documentation says:This means be able to run and pass this test (
set
andget
a parameter without connection):