qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
31 stars 3 forks source link

Drivers touch things out of place #76

Closed rsagas closed 1 year ago

rsagas commented 2 years ago

Qblox Drivers are too aware of qpysecuence .

Drivers should not use qpysequence. Qpysequence solves a problem that comes above (and the driver should not even be aware).

Specifically, Qpysequence generates the M sequences corresponding to M AWGs/digitizers that need to be in synchrony and corresponding to the desired program/sequence/circuit/experiment.

The driver should JUST take that as an input.

Otherwise, one runs into problems where a layer needs to know things/concepts/modules that do not belong to that concept layer (for example, Qblox hardware not being possible to run without qpysequence, even if user is smart enough to provide a json)

rsagas commented 2 years ago

This was also request in issue #74