qilimanjaro-tech / qililab

Qililab is a generic and scalable quantum control library used for fast characterization and calibration of quantum chips. Qililab also offers the ability to execute high-level quantum algorithms with your quantum hardware.
Apache License 2.0
30 stars 2 forks source link

Fixed float numbers for Voltage ad float scalar #789

Closed jordivallsq closed 2 weeks ago

linear[bot] commented 2 weeks ago

QHC-726 Incopatible domain.Voltage iterations value

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.86%. Comparing base (760c13b) to head (4db764c). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #789 +/- ## ======================================= Coverage 95.86% 95.86% ======================================= Files 271 271 Lines 8807 8809 +2 ======================================= + Hits 8443 8445 +2 Misses 364 364 ``` | [Flag](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/789/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/qilimanjaro-tech/qililab/pull/789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech) | `95.86% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qilimanjaro-tech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

visagim commented 2 weeks ago

confirm that this change in stop does not enter in conflict with calculate_iterations at

https://github.com/qilimanjaro-tech/qililab/blob/92c8a4e38d06f0545582998a887de112118ecdc6/src/qililab/qprogram/quantum_machines_compiler.py#L543-L556

I dont think it does but just to be sure

jordivallsq commented 2 weeks ago

It does not, I checked this already in debug mode