Closed mochaaP closed 9 months ago
cc @xwings please review :)
code looks good to me. one more approve we are good to go
Any ideas on the eth_abi v4 thing? I literally have zero experience with Ethereum, updating to the new encode
API resulted in a different bytecode being emitted.
@nullableVoidPtr Hi, do you have time to take a look at this, since you authored #1111?
Looks good overall, but separating linting in a single commit would be fine. Anyway nice work!
This PR reminds me one thing, maybe we should really mention we only deal with python>=3.8
somewhere.
Just one more thing, could you test if the release CI breaks or not?
Just one more thing, could you test if the release CI breaks or not?
I tested it on my local machine with a dry run, no issue so far.
CI seems to be good. @wtdcode you might need to approve the code
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
Migrate the project to Poetry.
Supersedes #1111.