qilingframework / qiling

A True Instrumentable Binary Emulation Framework
https://qiling.io
GNU General Public License v2.0
5.14k stars 745 forks source link

deps: migrate to Poetry & pyproject.toml #1387

Closed mochaaP closed 9 months ago

mochaaP commented 1 year ago

Checklist

Which kind of PR do you create?

Coding convention?

Extra tests?

Changelog?

Target branch?

One last thing


Migrate the project to Poetry.

Supersedes #1111.

mochaaP commented 10 months ago

cc @xwings please review :)

xwings commented 10 months ago

code looks good to me. one more approve we are good to go

mochaaP commented 10 months ago

Any ideas on the eth_abi v4 thing? I literally have zero experience with Ethereum, updating to the new encode API resulted in a different bytecode being emitted.

mochaaP commented 9 months ago

@nullableVoidPtr Hi, do you have time to take a look at this, since you authored #1111?

wtdcode commented 9 months ago

Looks good overall, but separating linting in a single commit would be fine. Anyway nice work!

This PR reminds me one thing, maybe we should really mention we only deal with python>=3.8 somewhere.

wtdcode commented 9 months ago

Just one more thing, could you test if the release CI breaks or not?

mochaaP commented 9 months ago

Just one more thing, could you test if the release CI breaks or not?

I tested it on my local machine with a dry run, no issue so far.

xwings commented 9 months ago

CI seems to be good. @wtdcode you might need to approve the code