qilingframework / qiling

A True Instrumentable Binary Emulation Framework
https://qiling.io
GNU General Public License v2.0
5.11k stars 742 forks source link

Fix project metadata and Docker builds #1435

Closed mochaaP closed 8 months ago

mochaaP commented 9 months ago

Checklist

Which kind of PR do you create?

Coding convention?

Extra tests?

Changelog?

Target branch?

One last thing


mochaaP commented 9 months ago

/rr @elicn @xwings

mochaaP commented 9 months ago

It's not removed, it's wrapped into a run function so we can use it in the script entrypoint later.

elicn commented 9 months ago

Oh, I see.. I must have missed that.

elicn commented 9 months ago

@mochaaP, what's with that .gitignore? It is full of redundant auto-generated stuff. Can you reduce it to the absolute necessary?

mochaaP commented 9 months ago

I don't think that's a particularly big issue?

mochaaP commented 9 months ago

The gitignore is just https://github.com/github/gitignore/blob/main/Python.gitignore with a few extra additions (poetry local config, ruff cache and pyright config).

elicn commented 9 months ago

We strive to keep the code clean as much as possible. Please remove all redundant auto-generated additions.

mochaaP commented 9 months ago

Reduced to minimum while keeping the required for Poetry.

mochaaP commented 9 months ago

@xwings Ready for merge :)

mochaaP commented 8 months ago

Rebase & more cleanups.