Example fuzzer for RT-N12 B1 httpd

qilingframework / qiling

A True Instrumentable Binary Emulation Framework

https://qiling.io

GNU General Public License v2.0

5.06k stars 737 forks source link

Example fuzzer for RT-N12 B1 httpd #1480

Open libumem opened 2 months ago

libumem commented 2 months ago

Checklist

Which kind of PR do you create?

[x] This PR only contains minor fixes.
[ ] This PR contains major feature update.
[ ] This PR introduces a new function/api for Qiling Framework.

Coding convention?

[x] The new code conforms to Qiling Framework naming convention.
[x] The imports are arranged properly.
[x] Essential comments are added.
[ ] The reference of the new code is pointed out.

Extra tests?

[x] No extra tests are needed for this PR.
[ ] I have added enough tests for this PR.
[ ] Tests will be added after some discussion and review.

Changelog?

[x] This PR doesn't need to update Changelog.
[ ] Changelog will be updated after some proper review.
[ ] Changelog has been updated in my PR.

Target branch?

[x] The target branch is dev branch.

One last thing

[x] I have read the contribution guide

libumem commented 1 month ago

Try to adhere to PEP8 conventions, it really helps to keep the code clean and tidy

I've since run a linter to address this.

Use proper annotations also for return values, not only for arguments

Should be fixed now.

Add more comments explaining what you are doing; things that are obvious to you might not be for others

Added multiple comment sections to aid understanding.

I am not sure we are allowed to attach the firmware files here. If you have a direct like to the firmware on the vendor's website, that would be great

Removed firmware file (which was the wrong one anyway) and added a link to the manufacturer's page.

elicn commented 1 month ago

Great, thanks for making the changes. Please see the two remaining comments.

(Make sure to tag me, so I will get notified)

libumem commented 1 month ago

@elicn Addressed the feedback you gave. Much appreciated.

libumem commented 2 weeks ago

Will someone else please approve this?