qinboan / pe

0 stars 0 forks source link

Phone number does not allow characters such as "+" #7

Open qinboan opened 5 months ago

qinboan commented 5 months ago

There might be foreign students in singapore that might not have a Singaporean number (since everyone also uses tele handle now). Thus, allowing characters such as "+" would allow users to specify country code and add foreign numbers.

image.png

nus-pe-script commented 5 months ago

Team's Response

Thank you for this suggestion but the number can still be added without the "+" symbol. Additionally, this is the phone number field so we do not expect use of telegram handle. A separate field would have to be created. Therefore, good point raised, but not in scope. This should have also been categorised as a feature flaw.

The reason why this is not in scope is because the value that adding the "+" symbol gives is not a lot. Although it is clearer, it doesn't hinder the user so much, as after removing the "+", and other invalid syntax, a user can input in the number. The number itself is still easily identifiable as a foreign number, due to it's length.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: + was just an example of a country code. There are also many other special characters in foreign telephone numbers such as "*" and "#" which are many times also included in telephone keypads (look at the iPhone telephone keypad for example). Though they are not used in Singapore, they are essential parts of the telephone numbers in other countries. Hence it should be considered a valid point.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]