search

qing3962 / password-protection

This is a password plugin for protecting your private notes and diary, no encrypt, no decrypt.
MIT License
38 stars 6 forks source link

Cannot cancel password prompt #2

Closed johnoscott closed 1 year ago

johnoscott commented 1 year ago

I think you should be able to close the password prompt when being asked for the password. I was not able to close it without quitting the app on Mac OS.

yustarandomname commented 1 year ago

I experience the same issue on my M1 MacBook. Rest of the plugin works as expected

https://github.com/qing3962/password-protection/assets/25432790/b2bdd817-0497-477b-a118-227b1a0ad9c5

qing3962 commented 1 year ago

This was intentional.

Once the password prompt modal is opened, I don't want someone who doesn't know the password to be able to go on, Otherwise, it will expose the tree of directory and title of notes.

Rewind two versions, in the 1.0.9 version, the modal can be closed. If you really mind this feature, please download and use the 1.0.9 version?

yustarandomname commented 1 year ago

In that case, would it be more logical to remove the cross/close icon?

qing3962 commented 1 year ago

I accept your advise, I have remove the close button of verify password modal, please update to the latest vesion.

qing3962 commented 1 year ago

If the user forget the password, he wouldn't open the Obsidian, so I decide to allow user to close the verify password modal, I update the version again.

qing3962 commented 1 year ago

In the latest version v1.1.12, I have add the setting of prohibit close password verify box, this will provide more protection. If you enable the setting option, the password verify box wouldn’t be able to be closed as soon as it pop up, unless you type right password. Caution: If the protected folder you set is root path (/), and you forgot your password, you may not be able to enter the Obsidian.