search

qinhan620 / iperf

Automatically exported from code.google.com/p/iperf
0 stars 0 forks source link

move to a single periodic callback #14

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Explaination of new feature

simplify the API by defining a single callback for periodic use.  This can be 
used for intermediate 
results calculation, reporting, etc..

Justification of new feature

Original issue reported on code.google.com by jdugan.e...@gmail.com on 10 Dec 2009 at 6:57

GoogleCodeExporter commented 8 years ago 
Right now there are two periodic callbacks:
1.) stats_callback - calculates intermediate results and aggregates final result
2.) reporter_callback - does intermediate and final reporting

Should these two callbacks be kept separate?
Should the final result calculation and reporting be moved to separate 
independent callbacks?

Original comment by sethdell...@gmail.com on 27 Jul 2010 at 11:07

GoogleCodeExporter commented 8 years ago 
There are actually four timers - the abovementioned two, a non-periodic timer 
that says when the test is done, and for UDP tests bandwidth throttling is 
implemented via a timer.

Right now I'm almost done with the all-new timer system.  It makes use of 
timers simpler.  I'm inclined to think we should keep the multiple timers and 
mark this WontFix.

Original comment by jef.posk...@gmail.com on 10 Dec 2012 at 5:33

GoogleCodeExporter commented 8 years ago 
But we do have to make sure that the stats timer runs before the reporter 
callback.  I had to change a <= into a < in the timer package's queue sort 
routine to assure this.  Now if there's a tie, the timer added first runs first.

Original comment by jef.posk...@gmail.com on 12 Dec 2012 at 6:25

GoogleCodeExporter commented 8 years ago

Original comment by bltier...@es.net on 12 Dec 2012 at 10:41