search

qinhan620 / iperf

Automatically exported from code.google.com/p/iperf
0 stars 0 forks source link

Option for setting Flow Label field in IPv6 header #40

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Explaination of new feature
An option to set the Flow Label field in the IPv6 header for an outgoing stream 
on the client side.

Justification of new feature
To permit the testing of IPv6 QoS implementations based on the Flow Label field.

Original issue reported on code.google.com by andre.go...@gmail.com on 15 Apr 2011 at 8:48

GoogleCodeExporter commented 8 years ago

Original comment by bltier...@es.net on 12 Mar 2013 at 10:45

GoogleCodeExporter commented 8 years ago 
It turns out to be surprisingly difficult to find working examples of how to 
set the Flow Label field.  Really not very much in google.  Maybe people aren't 
doing much of this yet?

I did put in my best guess at how to do it, but tcpdump showed that the field 
was not getting set.

Original comment by jef.posk...@gmail.com on 3 Jun 2013 at 12:58

GoogleCodeExporter commented 8 years ago 
Could not figure out how to do this, so pushing this back a release. Can anyone 
help figure this out?

Original comment by bltier...@es.net on 23 Jul 2013 at 5:33

GoogleCodeExporter commented 8 years ago 
Hi,
  I wrote a patch which enables flow label for ipv6 feature. It is only with TCP.

Original comment by susant.sahani on 30 Nov 2013 at 1:57

Attachments:

GoogleCodeExporter commented 8 years ago 
Wow, that is much more complicated than I expected!

Original comment by jef.posk...@gmail.com on 30 Nov 2013 at 2:35

GoogleCodeExporter commented 8 years ago 
HI there,
             Well I am not sure is this the right way to submit the patches. Please let me know the process  of submitting patches.

Thanks,
Susant
ssahani@redhat.com

Original comment by susant%redhat.com@gtempaccount.com on 6 Dec 2013 at 5:34

GoogleCodeExporter commented 8 years ago 
that works great. Thanks!

Original comment by bltier...@es.net on 6 Dec 2013 at 6:23

GoogleCodeExporter commented 8 years ago 
Thanks for submitting the patch!

One bit of feedback I have is that this patch, as-is, will break compiles on 
non-Linux systems, or more exactly anything that doesn't support the 
IPV6_FLOWLABEL_MGR and IPV6_FLOWINFO_SEND socket options (for example, among 
the hosts that I work with, it would break compiles on FreeBSD and MacOS).  
It'd make sense for these code changes to be conditionally compiled on Linux 
systems only.

I haven't reviewed the patch for functionality yet.

Original comment by bmah@es.net on 10 Dec 2013 at 12:02

GoogleCodeExporter commented 8 years ago 
 Yes agree it should be only for linux . I did modified the patch to be linux specific so that the compilation should not break on other systems.

tested with $ ./iperf3 -c ::1 -L 24

 Here is  is captured packet dump

.... .... .... 0000 0000 0000 0001 1000 = Flowlabel: 0x00000018

Original comment by susant%redhat.com@gtempaccount.com on 10 Dec 2013 at 10:30

Attachments:

GoogleCodeExporter commented 8 years ago 
I tested the second version of this patch and it seems to Do The Right Thing 
(TM).

I don't have time to commit this right at the moment but hopefully within the 
next day or two I'll take care of this.

Thanks for submitting this!

Note to self:  Before committing, remember to uncomment the -L option in the 
manpage and fix up a couple comments in iperf_api.c.

Original comment by bmah@es.net on 12 Dec 2013 at 12:32

GoogleCodeExporter commented 8 years ago 
Committed a slightly modified version of the patch in 2ad1efdb977e.

Closing as fixed.

Original comment by bmah@es.net on 12 Dec 2013 at 5:25

GoogleCodeExporter commented 8 years ago 
It only took me two tries to get this committed correctly.  b6497ec1f4dd adds a 
file I forgot to commit the first time.

Original comment by bmah@es.net on 12 Dec 2013 at 5:38