Codecov Report

Merging #225 into master will increase coverage by 3.37%. The diff coverage is 72.46%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   59.89%   63.27%   +3.37%     
==========================================
  Files          22       25       +3     
  Lines        1960     1985      +25     
==========================================
+ Hits         1174     1256      +82     
+ Misses        619      561      -58     
- Partials      167      168       +1

Impacted Files	Coverage Δ
storage/resume_uploader_deprecated.go	`0.00% <0.00%> (ø)`
storage/form_upload.go	`53.96% <55.55%> (+2.57%)`	:arrow_up:
storage/resume_uploader_v2.go	`67.64% <67.64%> (ø)`
storage/uploader_base.go	`71.42% <71.42%> (ø)`
storage/resume_uploader.go	`75.63% <75.63%> (ø)`
storage/resume_uploader_base.go	`77.19% <77.19%> (ø)`
storage/resume_uploader_apis.go	`82.07% <82.07%> (ø)`
storage/base64_upload.go	`67.21% <100.00%> (+3.57%)`	:arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e270d8...92104bd. Read the comment docs.

bachue commented 4 years ago

仅七牛内部员工可见：QIN-3

Mei-Zhao commented 4 years ago

/lgtm

qiniu-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bachue, Mei-Zhao, YangSen-qn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/qiniu/api.v7/blob/master/OWNERS)~~ [Mei-Zhao,bachue] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Mei-Zhao commented 4 years ago

服务端新版分片上传还有2个问题，修复后预期与当前行为不兼容，暂时先不对外发布

qiniu / api.v7

分片上传 v2 #225

Codecov Report