CarlJi commented 2 years ago

fix #303

qiniu-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CarlJi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/qiniu/goc/blob/master/OWNERS)~~ [CarlJi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 2 years ago

Codecov Report

Merging #305 (683b20d) into master (6795ec7) will decrease coverage by 0.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   70.85%   70.66%   -0.20%     
==========================================
  Files          34       34              
  Lines        2035     2035              
==========================================
- Hits         1442     1438       -4     
- Misses        480      483       +3     
- Partials      113      114       +1

Flag	Coverage Δ
e2e-1.16.x	`?`
e2e-1.17.x	`?`
e2e-1.18.x	`?`
e2e-1.19.x	`?`
unittest-1.16.x	`70.66% <ø> (-0.10%)`	:arrow_down:
unittest-1.17.x	`70.66% <ø> (ø)`
unittest-1.18.x	`70.66% <ø> (-0.10%)`	:arrow_down:
unittest-1.19.x	`70.66% <ø> (-0.20%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cover/instrument.go	`20.83% <ø> (ø)`
pkg/build/gomodules.go	`89.18% <0.00%> (-5.41%)`	:arrow_down:
pkg/build/legacy.go	`95.12% <0.00%> (-4.88%)`	:arrow_down:

qiniu / goc

chore: rename log package in order to avoid conflict #305

Codecov Report