Closed bianjp closed 8 years ago
@longbai Any responsible for this?
+1
LGTM,Thanks
@longbai Can you release a new version?
好的
@bianjp done
👍
@longbai You reverted json
dependency from >= 1.8.0
to ~> 1.8.0
in this commit. Can you change it back to >= 1.8.0
or ~> 2.0.0
?
json
2.0 droped support for Ruby < 2.0, but since qiniu
has already droped support for Ruby <= 2.0 from 6.7, this should not be a problem. See its changelog for more.
By the way, updating mime-types dependency to 3.x would be great.
@bianjp 我来看下
rest-client
1.8.0 seems to have a memory leak. I'm not sure how to exactly determine whether it has a memory leak, but according to the following simple test, 2.0.0 uses much less memory and time than 1.8.0.I find this when trying to address the memory leaks in my rails application. One api that use
rest-client
causes the memory usage grows continuously. If usingrest-client
2.0.0, the memory usage will stop growing after reaching a fixed value.rest-client
2.0.0 is largely API compatible with 1.8.0, and qiniu should work correctly with it. Seerest-client
history for more.