search

qiniu / ruby-sdk

Qiniu Resource (Cloud) Storage SDK for Ruby
MIT License
164 stars 138 forks source link

Support Ruby 2.4 #183

Closed tombruijn closed 7 years ago

tombruijn commented 7 years ago

Support Ruby 2.4 by bumping the json dependency.

I recommend #182 is merged beforehand.

tombruijn commented 7 years ago

Looks like it's still trying to install the wrong json version on 2.4 on travis. I'll have another look at it tomorrow

longbai commented 7 years ago

@tombruijn Thank you very much.

bianjp commented 7 years ago

It should be better to remove the json dependency, as it's included in 1.9.3+ already, and this project only supports Ruby 2.1+.

tombruijn commented 7 years ago

Dependency removed, but looks like something changed in the json lib this gem relies on. The Ruby 2.4 specs keep failing.

swelther commented 7 years ago

It's green on my machine, but only with PR #182 merged. Maybe that's the reason it fails on travis?

nazarok commented 7 years ago

+1

kesha-antonov commented 7 years ago

Hello guys! Are you planning to merge?

tombruijn commented 7 years ago

Since the test suite fails dramatically on 2.4 I can't recommend merging this as is. Someone needs to take a look at fixing whatever is failing, but that's beyond my understanding of this gem.

songjiayang commented 7 years ago

Hi, @tombruijn it's fixed in #195, check again please

tombruijn commented 7 years ago

Great! Thanks!