search

qiniu / ruby-sdk

Qiniu Resource (Cloud) Storage SDK for Ruby
MIT License
164 stars 138 forks source link

Qiniu::RS::upload_file should raise exception when failed, instead of return false #19

Closed lidaobing closed 12 years ago

lidaobing commented 12 years ago

see also lidaobing/backup2qiniu#1

when upload_file failed, currently it return false, I think it has two problems

  1. it hide the real problem cause this failure.
  2. upload_file is an important operation, and not every one remember check the result, if it failed silently, maybe the user's data will lost
why404 commented 12 years ago

good idea! I'll fix this problem

why404 commented 12 years ago

fixed https://github.com/qiniu/ruby-sdk/pull/20