search

qiqitori / reply_as_original_recipient

This Thunderbird extension automatically changes the "From" field in replies to whatever the original sender's email had in "To" or "CC", but only if exactly one email address from all "To" and "CC" headers matches a configurable pattern.
https://blog.qiqitori.com/?p=194
Mozilla Public License 2.0
19 stars 10 forks source link

Update for Thunderbird 68 #3

Open malnvenshorn opened 5 years ago

malnvenshorn commented 5 years ago

It would be great if you could update your plugin to work with Thunderbird 68.

noplanman commented 5 years ago

Me too!

Unfortunately I can't get it to work even when manually tweaking the max version in install.rdf :confused:

esdeboer commented 4 years ago

User Yves has posted an updated version for Thunderbird 68 in a comment (oct 28) on this extensions blog post: https://blog.qiqitori.com/?p=194

RonOnThePond commented 4 years ago

Also hoping for Thunderbird 68.3.1 update. I use this all day long with catch-all addresses, and really depend on it. Saves me a TON of time. I will keep hoping ... will take a look at the link provided by esdeboer (thank you).

noplanman commented 4 years ago

Unfortunately the linked extension doesn't work with TB 6.3.1. I really hope the necessary changes get merged to get this working again.

RonOnThePond commented 4 years ago

Take a look at the update 1.5 posted by Yves October 28, 2019 here; https://blog.qiqitori.com/?p=194#comment-7975 So far, it's working great for me with Thunderbird 68.3.1. Good luck!

noplanman commented 4 years ago

Ah, it does work! I didn't adjust the pattern and just saw that out of the box it requires a + in the address. Changing the pattern to * fixed it :tada:

wienfuchs commented 4 years ago

https://blog.qiqitori.com/?p=194#comment-7972 works fine for me too, thanks

NicolasGoeddel commented 4 years ago

How do I install the version for Thunderbird 68? This link only offers a version up to Thunderbird 64.x: https://addons.thunderbird.net/de/thunderbird/addon/reply-as-original-recipient/ Or do I still need to download the xpi file from here? https://unclassified.de/tmp/reply_as_original_recipient-1.5-tb.xpi

NicolasGoeddel commented 4 years ago

Huh? Upcoming version 78? Why do I have 68 then? Will they make a big jump from 68 to 78? On Ubuntu Focal there is only 68.10 available. Are they going to change the whole ecosystem again? Oh noooo.... :-(

wienfuchs commented 4 years ago

Huh? Upcoming version 78?

https://www.thunderbird.net/en-US/thunderbird/78.0.1/releasenotes/ Yes, will be a big jump, most addons will not work anymore.

And sorry, I deleted my previous comment (that you replied to) - to see, if the latest commit as from February will make it working as documented on the startpage of this repository. And yes, it does, so you may simply follow the described way from README.md

qiqitori commented 4 years ago

@NicolasGoeddel You can download the repo (via git clone or zip file), and then create a zip file from the files contained in the repo. If you download a zip file, GitHub will put the contents of the repo in a subfolder so you'll have to do something like:

unzip reply_as_original_recipient-master.zip
cd reply_as_original_recipient-master/
zip -r foobar.xpi *

And then you can load that into Thunderbird. Changing extensions to work with newer versions is probably pretty fiddly so I don't think I'll port the code to 78. If somebody does, I'll merge though. Maybe I'll even manage to update the extension on the Thunderbird website.

noplanman commented 4 years ago

@qiqitori It would be really awesome if you (or somebody else) could port it to 78, as I'm really missing the functionality now. This plugin really should be part of Thunderbird itself, it's just such an essential feature!

So if you or anybody else do ever feel inspired to give it a got, my gratefulness is with you 🙏

func0der commented 4 years ago

You do not need the extension anymore, if you use Thunderbird 78. The guy from virtual Identity tried to get the feature into the core of Thunderbird and succeeded.

Here is his intention and in there you'll find the link to the resolved bugzilla issue for this topic ;) https://github.com/absorb-it/Virtual-Identity/issues/22#issuecomment-539075574

noplanman commented 4 years ago

@func0der Perfect, thanks so much for that! 🙏

From my initial tests, it seems to be working correctly with the new account setting.

For everybody coming here and not knowing where to look or how to set it up: Look here: https://bugzilla.mozilla.org/show_bug.cgi?id=1518025#c115

The setting is in the Account Settings, called Reply from this identity when delivery headers match. Checking that setting and adding *@ into the input field should do it.

Gurthurb commented 4 years ago

@qiqitori @noplanman @func0der I've ported the extension to a MailExtension in the simplest way possible (following the instructions, using the WindowListener API).

I could make it a pull request, but since it isn't backwards compatible and removes files (and I've never made a pull request before) I'm a bit reluctant to do that, so instead I'm attaching the .zip file to this message for now.

Since I'm not sure exactly which version of Thunderbird it requires, I set it to 78.0 minimum.

It appears to work 100%, but no promises, I'm not an extension developer. :smile:

Oh, and please feel free to check the code before running it; don't just trust a random guy on the internet. :smirk:

reply_as_original_recipient-mailextension.zip

Rename it to .xpi to make it installable.

popindavibe commented 3 years ago

As Debian rolled out 78 in stable, it would be great to have that compatible version shipped in directly from Thunderbird extensions.

thutex commented 3 years ago

You do not need the extension anymore, if you use Thunderbird 78. The guy from virtual Identity tried to get the feature into the core of Thunderbird and succeeded.

Here is his intention and in there you'll find the link to the resolved bugzilla issue for this topic ;) absorb-it/Virtual-Identity#22 (comment)

not perfect, unfortunately.... i use real@example.com as mailbox, and for example name@example.com and stuff@example.com as alias. mail gets filtered into the right folder by sieve, all have only 1 identity: real@example.com.

using *@ i see that in some cases it seems to match incorrectly

wienfuchs commented 3 years ago

I've ported the extension to a MailExtension in the simplest way possible ... It appears to work 100%, but no promises, I'm not an extension developer. 😄

That works wonderful fine at least for me. Thank you for that. Just to clarify, the functionality I need and got from this is, when I answer and have an matching identity configured, I want this to be selected and not placed into "cc" on "reply to all". That's what https://github.com/qiqitori/reply_as_original_recipient/issues/3#issuecomment-706601538 delivers to me in a perfect way. Again, thank you.

mathisdt commented 3 years ago

@Gurthurb Please, if you have time for it, submit your code as a pull request. I use it every day and experienced no issues with it so far. It would be nice to have the working version of the code incorporated into the original repository!

Gurthurb commented 3 years ago

@wienfuchs @mathisdt Ok, I'll have a go at creating a pull request, since I have a little more github experience now. I'll let you know when it happens!

My fix unfortunately doesn't seem to work in the upcoming Thunderbird 80 though; maybe the WindowListener API has been dropped in that release? If so, I'm afraid I'll be in over my head so somebody else will have to pick up the torch then. But we'll see. I very much need this extension to work for myself, so if all else would fail I guess I'd have to learn how to implement it "properly" (if it's actually possible, with the new(er) APIs).

Gurthurb commented 3 years ago

@wienfuchs @mathisdt Pull request submitted: https://github.com/qiqitori/reply_as_original_recipient/pull/8

veganDE commented 3 years ago

@Gurthurb Any success trying to port the functionality using the new MailExtension API?

I've tried my luck (having no addon experience beforehand whatsoever), but I cannot find a way to modify the "from" field.

compose.getComposeDetails and compose.setComposeDetails look promising, but:

getComposeDetails():

Currently only a limited amount of information is available, more will be added in later versions.

setComposeDetails():

Updates the compose window. Specify only fields that you want to change. Currently only the to/cc/bcc/replyTo/followupTo/newsgroups fields and the subject are implemented. It is not possible to change the compose format.

So the setComposeDetails() is currently missing a "from" field (or similar) to modify the sender address.
I'm not sure if setComposeDetails() is even intended to be able to modify the sender in the future (in which case we are stuck on waiting until this is implemented?), or if there is another API function intended to achieve this.

As getComposeDetails() refers to the currently composed mail (and not the original one we are replying to, neither linking to it), there is no way to read the original recipient address using getComposeDetails() – as far as my understanding goes.

However, using limited testing, I found out that mailTabs.getSelectedMessages() seems to refer to the original mail the current reply is being composed to, which allows to extract the original recipient address, though it may be unreliable in certain circumstances.

So.... more research is needed here. I'm out of ideas for now. (Maybe the MailExtensions Experiments can help if necessary?)

edit: the from field is being added to ComposeDetails in Thunderbird 88! However, there is still no straightforward way to get a backreference to the original message being replied on, and it may need an API update. The next non-beta Thunderbird release after the current TB78 will be TB91 in the middle of August.

Gurthurb commented 3 years ago

@Gurthurb Any success trying to port the functionality using the new MailExtension API?

I haven't looked at it, but now that I've upgraded to TB91 my quick'n'dirty intermediary port no longer works, so I may have to give it a try...

Any progress since your last update?

veganDE commented 3 years ago

@Gurthurb I haven't looked into it yet any further since my last comment here, unfortunately.

However, the Matrix channel I've linked in my previous comment was a great help/insight and I can recommend it in case you encounter any questions!

Gurthurb commented 3 years ago

We may have been saved by a new setting in Thunderbird, which appears to render this extension obsolete:

https://github.com/qiqitori/reply_as_original_recipient/issues/10

Checking "Reply to this identity when delivery headers match" and setting its value to *@mydomain.com appears to work perfectly. If I reply to an e-mail sent to anything@mydomain.com, the from-address will be the same anything@mydomain.com.

I don't know if there are any other special cases this extension covers that Thunderbird still doesn't cater for?

Johann-Tree commented 2 years ago

I tested the “Reply to this identity when delivery headers match” function in Thunderbird 78.14.0 and Daily build 98.0a1 (2022-01-18) with plus addresses and it did not work as expected: I set following regex: anything+*@example.org

Received an email to: anything+domain.com@example.org When replying, +domain.com is not used as the from address, only anything@example.org.

The Mail extension created by Gurthurb https://github.com/qiqitori/reply_as_original_recipient/issues/3#issuecomment-706601538 works perfect in Thunderbird 78!

I opened a bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1750835