incorporate changes probably from Samuel Kirschner and Yves

qiqitori / reply_as_original_recipient

This Thunderbird extension automatically changes the "From" field in replies to whatever the original sender's email had in "To" or "CC", but only if exactly one email address from all "To" and "CC" headers matches a configurable pattern.

https://blog.qiqitori.com/?p=194

Mozilla Public License 2.0

19 stars 10 forks source link

incorporate changes probably from Samuel Kirschner and Yves #5

Closed mathisdt closed 4 years ago

mathisdt commented 5 years ago

make matching pattern configurable via preference extensions.replyasoriginalrecipient.patterns
use manifest.json instead of install.rdf
compatibility to Thunderbird 68

also see the corresponding comments at https://blog.qiqitori.com/?p=194

qiqitori commented 5 years ago

BTW, can you briefly state in the commit message(s) which changes were needed to make this work in TB68?

mathisdt commented 5 years ago

I'm afraid I can't tell what was needed to support TB68 - as I stated in the title, Samuel and Yves did the coding. I only created this PR to consolidate their changes which I got from the links in their comments on https://blog.qiqitori.com/?p=194.

mathisdt commented 4 years ago

@qiqitori, probably the use of manifest.json instead of install.rdf helps with the compatibility to TB68, but I'm not an extension developer so I don't really know if this is the only necessary change.

mathisdt commented 4 years ago

Can I help with something else, or are you confident enough with the changes to merge this PR?

mathisdt commented 4 years ago

@qiqitori I'd like to kindly ask if there is any obstacle to be overcome or if this PR can be merged? As far as I can see, all of your comments are addressed.

qiqitori commented 4 years ago

Indentation still looks a bit wonky but I'm gonna merge anyway

qiqitori commented 4 years ago

@mathisdt Merged. BTW -- I don't really remember how to test this extension (I just made it on request for someone). Can you confirm that the code still works and that the default behavior is still the same as the original extension?

mathisdt commented 4 years ago

First I used the original extension, then this version. Both worked similar, but with this version there are more options which makes it more fun to use. And yes, I can confirm that the default behaviour is the same (changing the sender address automatically for replies).