search

qir-alliance / pyqir

PyQIR is a set of APIs for generating, parsing, and evaluating Quantum Intermediate Representation (QIR).
https://qir-alliance.github.io/pyqir
MIT License
58 stars 24 forks source link

Add mypy to CI #57

Closed bamarsha closed 2 years ago

bamarsha commented 2 years ago

We have type annotations and mypy stub files (.pyi) that aren't checked during CI, so they can drift out of sync with the implementation. We should run mypy during CI to catch these issues. This should be done as a build task run as part of the checks tasks.

WingCode commented 2 years ago

@samarsha / @idavis Forgot to ask, could you assign the issue to me?

idavis commented 2 years ago

Hi @WingCode ! Thanks for the contribution. Would you be willing to update the implementation to match the way the clippy task is implemented? I don't fully trust actions that aren't very well known. Then it can be run on the command line locally and done via the CI for validation. I apologize that this wasn't specified clearly in the issue description.

WingCode commented 2 years ago

@idavis Yes, definitely. That makes sense 👍