CI improvements - Githubissues

qir-alliance / qat

QIR compiler tools and optimization passes for targeting QIR to different hardware backends

https://qir-alliance.github.io/qat/

MIT License

26 stars 14 forks source link

CI improvements #104

Closed troelsfr closed 2 years ago

troelsfr commented 2 years ago

This PR introduces:

Trunk to enforce formatting and static analysis
Bazel to allow building QAT with LLVM from source
Windows build support
Bug fixes for undefined behaviour
Reformatting of a large portion of files
Extended Github actions CI including debug builds to ensure that LLVM asserts are fulfilled
Improves qat filesize from 140 mb down to 25 mb (8 mb if gzipped)
A debian slim Docker container containing that has a size of 102 mb

Please note that merge is contingent on approval of use of Trunk. @bettinaheim is looking into this.

swernli commented 2 years ago

I'm still ramping up on what Bazel is and how it is used here, but it seems odd to me that there is an empty top level BUILD file. Is this intentionally left blank to represent that there are no dependencies at the top level? If so, it would be worth a comment in there clarifying that.

troelsfr commented 2 years ago

I'm still ramping up on what Bazel is and how it is used here, but it seems odd to me that there is an empty top level BUILD file. Is this intentionally left blank to represent that there are no dependencies at the top level? If so, it would be worth a comment in there clarifying that.

Yes, that is intentional that it is there. Do not worry too much about the Bazel stuff if you are not familiar with Bazel. Rather focus on the code changes which for the bigger part is formatting.