search

qir-alliance / qir-spec

QIR specification defining how to represent quantum programs within the LLVM IR
Other
68 stars 19 forks source link

Adding output schemas #32

Closed idavis closed 1 year ago

idavis commented 1 year ago

This PR defines the output schemas for labeled and unlabeled schemas.

The format also defines what the output should look like for output recording functions for int, double, and bool which are not currently specified in the base profile. We can remove these functions from the schemas or keep them noting that they are forward looking definitions.

This spec, along with the base profile will have to be updated as we address the opaque pointer updates to LLVM IR.

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All Contributors have signed the CLA.

idavis commented 1 year ago

I have read the Contributor License Agreement and I hereby accept the Terms.

idavis commented 1 year ago

Hi @bettinaheim, could you please review the schema definitions?

idavis commented 1 year ago

See #23

idavis commented 1 year ago

@bettinaheim /bump

idavis commented 1 year ago

/CC @qci-amos @kalzoo

idavis commented 1 year ago

While I understand why the method signatures are specialized, I wouldn't mind a sentence explaining why RESULT and BOOL outputs aren't emitted as INT.

Added a comment in Notes For Implementors

idavis commented 1 year ago

Thanks @qci-amos . I don't know of any OSS parsing utils for the output formats. Might be good to discuss at the next meeting. I don't have permissions to merge, so someone else will have to merge this PR.