search

qir-alliance / qir-spec

QIR specification defining how to represent quantum programs within the LLVM IR
Other
63 stars 18 forks source link

WIP: [Adding Specification for the Adaptive Profile] #35

Open peter-campora opened 1 year ago

peter-campora commented 1 year ago

Trying this again. I expect linting issues but hopefully no committer/CLA issues. Initial draft of the specification here for public comments.

github-actions[bot] commented 10 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the Contributor License Agreement and I hereby accept the Terms.

3 out of 4 committers have signed the CLA.
:white_check_mark: @peter-campora
:white_check_mark: @qartik
:white_check_mark: @bettinaheim
:x: @Bettina Heim
Bettina Heim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

qartik commented 10 months ago

I have read the Contributor License Agreement and I hereby accept the Terms.

echavarria-lrz commented 2 months ago

There is a typo here:

https://github.com/qir-alliance/qir-spec/blob/7dd5d2414f546d890d14fbe900a7ea2852d16df3/specification/under_development/profiles/Adaptive_Profile.md?plain=1#L307

echavarria-lrz commented 2 months ago

There is a typo here:

https://github.com/qir-alliance/qir-spec/blob/7dd5d2414f546d890d14fbe900a7ea2852d16df3/specification/under_development/profiles/Adaptive_Profile.md?plain=1#L310

echavarria-lrz commented 2 months ago

There is a typo here:

https://github.com/qir-alliance/qir-spec/blob/7dd5d2414f546d890d14fbe900a7ea2852d16df3/specification/under_development/profiles/Adaptive_Profile.md?plain=1#L393-L394

echavarria-lrz commented 2 months ago

Coin flip is spelled with and without a space within the same paragraph:

https://github.com/qir-alliance/qir-spec/blob/7dd5d2414f546d890d14fbe900a7ea2852d16df3/specification/under_development/profiles/Adaptive_Profile.md?plain=1#L395-L396

echavarria-lrz commented 2 months ago

This function is declared but never used:

https://github.com/qir-alliance/qir-spec/blob/7dd5d2414f546d890d14fbe900a7ea2852d16df3/specification/under_development/profiles/Adaptive_Profile.md?plain=1#L417

echavarria-lrz commented 2 months ago

There is a typo here:

https://github.com/qir-alliance/qir-spec/blob/7dd5d2414f546d890d14fbe900a7ea2852d16df3/specification/under_development/profiles/Adaptive_Profile.md?plain=1#L476