search

qiscus / qiscus-sdk-android

Qiscus provide everything you need to power up your app with chats. And it's now made simple.
https://www.qiscus.com
Apache License 2.0
201 stars 84 forks source link

remove update comment status on channel room #51

Closed asyrofqomaruddin closed 6 years ago

andhikayuana commented 6 years ago

@asyrofqomaruddin pak apop, jalanin check style di lokal pak

./gradlew check
zetbaitsu commented 6 years ago

pak @asyrofqomaruddin dibanding kita banyak nambahin kode di berbagai tempat, terus Qiscus.getDataStore().getChatRoom(getRoomId()); itu jg bakal jalan di UI thread tiap kali kita mau cek ini di dari channel atau bukan, kayaknya lebih baik kalo edit di https://github.com/qiscus/qiscus-sdk-android/blob/master/chat/src/main/java/com/qiscus/sdk/data/remote/QiscusPusherApi.java#L322 aja pak, chainning rx nya ditambahin, sebelum panggil api ambil roomnya dan cek apakah channel atau bukan disitu, baru di flatmap ke rest api kalau dia channel