search

qiskit-community / Quantum-Challenge-Grader

Grading client for the IBM Quantum Challenges
Apache License 2.0
44 stars 46 forks source link

badge 5 validation update: use new dataset and check score #120

Closed HuangJunye closed 1 year ago

HuangJunye commented 1 year ago

use new dataset and check score instead of sending QSVC

Astri-Cornish commented 1 year ago

lgtm

quantum-kittens commented 1 year ago

@HuangJunye Thank you! I have some questions/clarifications here.

HuangJunye commented 1 year ago

@Astri-Cornish @quantum-kittens If you think the PR is ok, can you give an official approval so that @vabarbosa can merge it?

vabarbosa commented 1 year ago

two questions...

  1. is it OK that the train/test data is static (i.e., constant values that dont change in subsequent tries)
  2. is it OK that the train/test data is in the client (i.e., visible to anyone if they knew where/what to look for)
HuangJunye commented 1 year ago

Thanks for the questions Va!

two questions...

1. is it OK that the train/test data is static (i.e., constant values that dont change in subsequent tries)

I personally think it's ok that the data is static because quantum explorers are not a competition in a way that challenges may appear to be. The answer to the question is easier than people finding ways to pass the grader with classical workarounds. That said, I would like hear @quantum-kittens opinions

2. is it OK that the train/test data is in the client (i.e., visible to anyone if they knew where/what to look for)

That is ok because the data is already present in the notebook. The data is hardcoded in the client because if we take the data as argument, users can input their own data.

vabarbosa commented 1 year ago

@HuangJunye thanks for the quick response and updates.