A Givens rotation can in general be complex-valued, but apply_givens_rotation currently only represents a real Givens rotation. It could be generalized by adding a phase angle phi. An alternative would be to define a function that takes the matrix entries c: float and s: complex.
kevinsung
commented
1 month ago
A Givens rotation can in general be complex-valued, but
apply_givens_rotationcurrently only represents a real Givens rotation. It could be generalized by adding a phase anglephi. An alternative would be to define a function that takes the matrix entriesc: floatands: complex.