qiskit-community / ffsim

Faster simulations of fermionic quantum circuits.
https://qiskit-community.github.io/ffsim/
Apache License 2.0
19 stars 5 forks source link

use one_body_linop in doublefactorized and diagonalcoulomb hamiltonians #268

Closed kevinsung closed 2 days ago

kevinsung commented 2 days ago

Not faster

| Change   | Before [3f88f70b] <main>   | After [45714c68] <pull/268/head>   |   Ratio | Benchmark (Parameter)                                                                      |
|----------|----------------------------|------------------------------------|---------|--------------------------------------------------------------------------------------------|
| +        | 9.71±0.3ms                 | 14.2±0.2ms                         |    1.46 | linear_operator.LinearOperatorBenchmark.time_diagonal_coulomb_hamiltonian_ffsim(12, 0.25)  |
| +        | 261±10ms                   | 369±4ms                            |    1.42 | linear_operator.LinearOperatorBenchmark.time_diagonal_coulomb_hamiltonian_ffsim(12, 0.5)   |
| +        | 34.8±3ms                   | 42.2±0.6ms                         |    1.21 | linear_operator.LinearOperatorBenchmark.time_double_factorized_hamiltonian_ffsim(12, 0.25) |
| +        | 979±5ms                    | 1.10±0s                            |    1.13 | linear_operator.LinearOperatorBenchmark.time_double_factorized_hamiltonian_ffsim(12, 0.5)  |
| -        | 1.75±0.08ms                | 1.36±0.01ms                        |    0.78 | linear_operator.LinearOperatorBenchmark.time_diagonal_coulomb_hamiltonian_ffsim(8, 0.5)    |
| -        | 1.18±0.09ms                | 483±10μs                           |    0.41 | linear_operator.LinearOperatorBenchmark.time_diagonal_coulomb_hamiltonian_ffsim(8, 0.25)   |