qiskit-community / monodromy

Computations in the monodromy polytope for quantum gate sets
Apache License 2.0
17 stars 9 forks source link

Dimension may be off-by-one on `cylinderize` #5

Open ecpeterson opened 3 years ago

ecpeterson commented 3 years ago

In most places, 'dimension' is treated as projective dimension, but cylinderize takes it to be affine dimension (i.e., the "constant" term is taken to contribute a dimension).

In general, we're somewhat inconsistent about whether the column of constants qualifies as a dimension or not, whether it needs to be specified as part of the cylinderization coordinate map, ... . We should pick a sane convention and stick to it.