search

qiskit-community / povm-toolbox

A toolbox for the implementation of positive operator-valued measures (POVMs).
https://qiskit-community.github.io/povm-toolbox/
Apache License 2.0
6 stars 0 forks source link

Split POVM and DUAL classes #10

Closed timmintam closed 1 month ago

timmintam commented 2 months ago

Closes #2

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

timmintam commented 1 month ago

Hey @mrossinek , I think this PR is in good enough shape to be merged now.

There are some points to improve, for instance how the DUAL classes and the POVMPostProcessor currently interact is not super clean. Also how the user can 'optimize' the dual frame as part of the post-processing could be cleaner...

But I think it is good enough for this PR, especially as the main goals of this PR (namely splitting POVM and DUAL classes) are achieved imo. We can tackle the points mentioned above in a follow-up PR (otherwise this one will get really too big).