Complete missing unittests - Githubissues

qiskit-community / povm-toolbox

A toolbox for the implementation of positive operator-valued measures (POVMs).

https://qiskit-community.github.io/povm-toolbox/

Apache License 2.0

30 stars 0 forks source link

Complete missing unittests #37

Closed timmintam closed 2 months ago

timmintam commented 3 months ago

Overall this looks good. Some minor comments/suggestions.

I will revisit unittests and documentation of these methods in a future PR.

Originally posted by @mrossinek in https://github.com/qiskit-community/povm-toolbox/pull/36#pullrequestreview-2113600710

This apply more generally: a global check for missing unittets and documentation would be useful. Complete the unittests for:

[x] quantum_info module
[x] library module
[x] sampler module
[x] post_processor module
[x] utilities file

timmintam commented 3 months ago

Double-check in all files:

[ ] __init__ replaced by setUp in all test files
[ ] random_circuit are saved to QASM files and loaded, instead of generating them in-line (see https://github.com/qiskit-community/povm-toolbox/pull/42#discussion_r1658607456)
[ ] fix a global seed for each test file