search

qiskit-community / prototype-qrao

Quantum random access optimization prototype
https://arxiv.org/abs/2111.03167
Apache License 2.0
27 stars 15 forks source link

Adaptive (n, 1, p)-QRACs #31

Closed areeq-hasan closed 2 years ago

areeq-hasan commented 2 years ago

Summary

Details and comments

garrison commented 2 years ago

There are (a lot of) changes in this pull request that are unrelated to its stated goal (and provided without justification). A good pull request should make a single logical change, ideally the minimal changes required to meet its goal, as smaller pull requests are much easier to review than longer ones.

That said, some of the suggested spelling substitutions might be improvements and should be considered separately, perhaps discussed in an issue first. I think it's worth saving this branch aside as is to keep a record. Any changes to interfaces, though, will break existing users of the code, so should be carefully considered, and if possible, the old names should be made to continue to work, keeping with the deprecation policy.

garrison commented 2 years ago

I'm going to close this, since it is being superseded by other PRs. There's a lot of good stuff in here, but we're going to make each change one at a time instead. It will nonetheless be useful to reference this from time to time.