qiskit-community / qiskit-algorithms

A library of quantum algorithms for Qiskit.
https://qiskit-community.github.io/qiskit-algorithms/
Apache License 2.0
116 stars 59 forks source link

Fix calling deprecated submit() #129

Closed woodsp-ibm closed 10 months ago

woodsp-ibm commented 10 months ago

Summary

Resolves #126

Details and comments

I chose to do this in a way that's compatible with the currently defined min Qiskit version and avoids deprecation warnings for future versions where in PrimitiveJob its now _submit()

I altered the text about an empty class its no longer true when looking at the source, and in the docs it not appear that way at all anyway since it showed all the inherited methods. I also added a note about the why submit() exists in it now and a TODO as a reminder to potentially revisit this in the future.

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 7582831436


Totals Coverage Status
Change from base Build 7582828207: 0.005%
Covered Lines: 6474
Relevant Lines: 7147

💛 - Coveralls