Fix power() in subclass test for QuantumCircuit change

qiskit-community / qiskit-algorithms

A library of quantum algorithms for Qiskit.

https://qiskit-community.github.io/qiskit-algorithms/

Apache License 2.0

111 stars 54 forks source link

Fix power() in subclass test for QuantumCircuit change #172

Closed woodsp-ibm closed 5 months ago

woodsp-ibm commented 5 months ago

Summary

Qiskit tests against main have been failing lint recently due to power() in QuantumCircuit gaining an extra parameter. With 1.1 going live shortly, where it will become the stable version tested against here, this amends the test to work and pass lint for existing versions of Qiskit e.g 0.46 and 1.0 as well as 1.1

Details and comments

As it's just a test case fix there is no reno needed. I marked this for backporting to stable as it will affect any builds done there once 1.1 releases.

woodsp-ibm commented 5 months ago

Oh, I see in the nightlies that mypy has been failing too recently. I'll see about fixing that in this PR too. At cursory glance it started with the latest mypy release.

qiskit_algorithms/gradients/reverse/derive_circuit.py: note: In function "derive_circuit":
qiskit_algorithms/gradients/reverse/derive_circuit.py:153: error: Incompatible types in assignment (expression has type "complex", variable has type "int")  [assignment]
Found 1 error in 1 file (checked 218 source files)

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8943306519

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.612%

Totals
Change from base Build 8804383908:	0.0%
Covered Lines:	6496
Relevant Lines:	7169