ADAM bug when calculating the gradient in batches #178

qiskit-community / qiskit-algorithms

A library of quantum algorithms for Qiskit.

https://qiskit-community.github.io/qiskit-algorithms/

Apache License 2.0

111 stars 54 forks source link

ADAM bug when calculating the gradient in batches #178 #183

Closed proeseler closed 1 month ago

proeseler commented 3 months ago

Summary

There is only one small error that prevents ADAM from calculating the gradient_num_diff for batches with max_evals_grouped. ADAM only gives "fun, self._eps" as argument when calling gradient_num_diff. This leads to max_evals_grouped=None, which leads to max_evals_grouped=1. Therefore, regardless of the call to set max_evals_grouped, max_evals_grouped=1 will always apply for ADAM.

Details and comments

This issue was discussed in #178

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10443892719

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.444%

Totals
Change from base Build 10319023971:	0.0%
Covered Lines:	6370
Relevant Lines:	7043

💛 - Coveralls

proeseler commented 1 month ago

Just tell me if there is anything else to do.