qiskit-community / qiskit-aqua

Quantum Algorithms & Applications (**DEPRECATED** since April 2021 - see readme for more info)
https://qiskit.org/aqua
Apache License 2.0
572 stars 377 forks source link

Fix migration guide and code msgs for aqua_globals #1566

Closed jplewa closed 3 years ago

jplewa commented 3 years ago

Summary

The migration guide currently says to replace qiskit.aqua.aqua_globals with qiskit.utils.aqua_globals, however qiskit.utils.aqua_globals does not seem to exist. It would appear that qiskit.utils.algorithm_globals is the correct import.

Details and comments

I updated README.md with what I believe to be the correct import. Apologies if I'm wrong - it's sort of hard to make sense of all these changes at once, so do correct me if I'm missing something :)

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

woodsp-ibm commented 3 years ago

Thanks for the correction - it was moved and later renamed. Seems that last part we slipped on an did not update here too.

FYI: CI is failing because of a problem in a library we use, where something it depends on was recently updated and has caused a breakage

manoelmarques commented 3 years ago

Thanks for noticing and fixing this. I added to this PR places in the code where the deprecation msg is wrong.