search

qiskit-community / qiskit-aqua

Quantum Algorithms & Applications (**DEPRECATED** since April 2021 - see readme for more info)
https://qiskit.org/aqua
Apache License 2.0
571 stars 377 forks source link

Update max_cut_value to handle weighted graphs #1597

Closed eendebakpt closed 3 years ago

eendebakpt commented 3 years ago

Summary

The max_cut_value method only handled graphs with edge weights equal to one. This updated the method to allow weighted graphs as well.

Details and comments

For the original max_cut_value no unittests where available. This PR add a few basic tests.

woodsp-ibm commented 3 years ago

HI, thanks for the contribution - however I'm afraid that Aqua was deprecated at the last release at start of April and while it is being supported in terms of maintaining code so it still runs against the rest of Qiskit and potentially fixing any critical bugs, no other changes such as new/changed function are otherwise being accepted.

Aqua was deprecated when the function it contained was moved elsewhere. So the functionality is not gone just re-located - some to Terra (algorithms and opflow) other domain code like ML and optimization to their own repos - you can read more here https://github.com/Qiskit/qiskit-aqua#migration-guide As part of the relocation the code was also refactored/improved etc

If you want to check out the max_cut as it now is you can see it here https://github.com/Qiskit/qiskit-optimization/blob/main/qiskit_optimization/applications/max_cut.py

peendebak commented 3 years ago

@woodsp-ibm Thanks for the update. I will close the PR.