Closed lukasvoss closed 7 months ago
Hi @lukasvoss, thank you for the contribution! This is a great feature. Please add some tests that cover the lines you've added and show that your changes work correctly.
Dear Lauren, dear Jean-Christophe,
I have implement some changes that are solving the errors arising from the qiskit naming convention of ParameterVector
elements by removing the squared-parenthesis from the parameter name.
@lukasvoss I took the liberty to push commits to your PR. Let me know if you are satisfied with the current implementation.
@jcjaskula-aws Thanks for your contribution, looks good to me!
@all: Thanks for all your contributions!
Summary
convert_qiskit_to_braket_circuit
function.Details
This could look something like this for a parametrized CNOT gate in qiskit: