search

qiskit-community / qiskit-braket-provider

Qiskit-Braket provider to execute Qiskit programs on quantum computing hardware devices through Amazon Braket.
https://qiskit-community.github.io/qiskit-braket-provider/
Apache License 2.0
58 stars 45 forks source link

Updates for Qiskit to Braket circuit conversion #97

Closed urihan closed 1 year ago

urihan commented 1 year ago

Summary

resolves #37 by changing Probability result type to Sample result type.

Details and comments

I have added an additional class, Observable, to the adapter.py file. Also updated the Sampler result type itself by adding an observable z as a parameter.

urihan commented 1 year ago

Hi @kshitijc, I am still working on this! I've been stuck on this error called Class 'Observable' has no 'Z' member (no-member) when running 'tox -elint' but it passes 'tox -epy39'. It is my first time contributing, so I am little lost with this error. Do you have a suggestion on fixing this error? Thank you!

kshitijc commented 1 year ago

Hi @kshitijc, I am still working on this! I've been stuck on this error called Class 'Observable' has no 'Z' member (no-member) when running 'tox -elint' but it passes 'tox -epy39'. It is my first time contributing, so I am little lost with this error. Do you have a suggestion on fixing this error? Thank you!

Sorry, I don't see Observable.Z() in your file diff. Could you please point me to the exact location where you are encountering this error?

urihan commented 1 year ago

Hi @kshitijc, I have finally fixed failing checks and also added a unit test! It would be great if you could check my submission. Thank you!