Small diffrax changes - Githubissues

qiskit-community / qiskit-dynamics

Tools for building and solving models of quantum systems in Qiskit

https://qiskit-community.github.io/qiskit-dynamics/

Apache License 2.0

106 stars 60 forks source link

Small diffrax changes #112

Closed brosand closed 2 years ago

brosand commented 2 years ago

Summary

Closes #110 by adding several small diffrax changes

Details and comments

Remove t_eval from diffrax_solver output, using result.t instead
adding an option in solve_lmde to use diffrax solvers by passing the instance of the solver into solve_ode
adding tests for calling solve_ode through solve_lmde for all solvers that are not lmde solvers
adding diffrax solver note to the solve_ode docs

brosand commented 2 years ago

Two notes to discuss:

the RK4 tests do not have the property is_ode_method, but they call solve_ode. Thus they are not running the test_ode_method test. This may be due to an older version of the tests.
In order to add an lmde test for the ode solvers (to test the pipeline), I added in separate solve_lmde methods to the ode solver tests. Just leaving a note to discuss other potential implementations.

DanPuzzuoli commented 2 years ago

Two notes to discuss:

the RK4 tests do not have the property is_ode_method, but they call solve_ode. Thus they are not running the test_ode_method test. This may be due to an older version of the tests.

In order to add an lmde test for the ode solvers (to test the pipeline), I added in separate solve_lmde methods to the ode solver tests. Just leaving a note to discuss other potential implementations.

I think the RK4 method not having is_ode_method is oversight, you can add this.