search

qiskit-community / qiskit-dynamics

Tools for building and solving models of quantum systems in Qiskit
https://qiskit-community.github.io/qiskit-dynamics/
Apache License 2.0
106 stars 60 forks source link

Add support for python 3.11 and remove for 3.7 #180

Closed DanPuzzuoli closed 1 year ago

DanPuzzuoli commented 1 year ago

Summary

Closes #169.

Adds Python 3.11 support, and removes Python 3.7 support. This is a remake of #179 as some required 3.7 tests wouldn't leave the job list for some reason.

Details and comments

The removal of 3.7 corresponds with the removal of 3.7 support from JAX, so it's maybe only a matter of time before 3.7 use of Dynamics + JAX becomes a problem.

DanPuzzuoli commented 1 year ago

@mtreinish There are some lingering 3.7 tests that don't appear to be running - I remade the PR because I thought maybe it was the PR that had gotten into some weird state, but this one is also having that issue.

mtreinish commented 1 year ago

Those jobs are listed as required in the branch protection rules. To remove them you'll have to go into the repo's branch protection settings and remove those jobs as being required to pass before merging (and likely add the 3.11 jobs too).

DanPuzzuoli commented 1 year ago

The only other place you might to update is https://github.com/Qiskit/qiskit-dynamics/blob/main/pyproject.toml#L6 for the black configuration. But it doesn't really matter, it just might change how black formats code (although I think in practice it doesn't actually change anything).

I have changed that one already :)