qiskit-community / qiskit-dynamics

Tools for building and solving models of quantum systems in Qiskit
https://qiskit-community.github.io/qiskit-dynamics/
Apache License 2.0
105 stars 61 forks source link

Updating solvers module to use arraylias #281

Closed DanPuzzuoli closed 10 months ago

DanPuzzuoli commented 1 year ago

Summary

This PR updates all of the solvers folder to use arraylias, aside from the perturbative_solvers folder, which must be updated after the perturbation folder.

The new release notes describe the material change to the interface:

Details and comments

All of the tests in the following command should be passing:

python -m unittest discover test.dynamics.models; python -m unittest discover test.dynamics.arraylias; python -m unittest discover test.dynamics.signals; python -m unittest discover test.dynamics.pulse; python -m unittest test.dynamics.solvers.test_diffrax_DOP5; python -m unittest test.dynamics.solvers.test_fixed_step_solvers; python -m unittest test.dynamics.solvers.test_jax_odeint; python -m unittest test.dynamics.solvers.test_lanczos; python -m unittest test.dynamics.solvers.test_solver_utils; python -m unittest test.dynamics.solvers.test_solver_functions; python -m unittest test.dynamics.solvers.test_solver_functions_interface; 
to24toro commented 10 months ago

https://github.com/Qiskit-Extensions/qiskit-dynamics/blob/88b2dfd357005f5241d0c059a814360059a91fae/qiskit_dynamics/models/__init__.py#L107

Also, need to fix it?

DanPuzzuoli commented 10 months ago

https://github.com/Qiskit-Extensions/qiskit-dynamics/blob/88b2dfd357005f5241d0c059a814360059a91fae/qiskit_dynamics/models/__init__.py#L107

Also, need to fix it?

yes good catch - for now I don't want to fix documentation, I think it should all be fixed at the end when all of the changes have been made (to avoid having to make further unexpected changes).