search

qiskit-community / qiskit-dynamics

Tools for building and solving models of quantum systems in Qiskit
https://qiskit-community.github.io/qiskit-dynamics/
Apache License 2.0
106 stars 60 forks source link

RWA arraylias conversion #296

Closed DanPuzzuoli closed 11 months ago

DanPuzzuoli commented 11 months ago

Summary

Converting rotating_wave_approximation.py to use arraylias.

I ended up adding the helper functions _to_dense and _to_dense_list in arraylias/alias.py as the to_array method had been being used in to convert everything to dense, and we need something analogous.

Details and comments

tests that need to be run before merge:

test.dynamics.models (whole folder) test.dynamics.arraylias (whole folder) test.dynamics.signals (whole folder) test.dynamics.pulse (whole folder)

CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

DanPuzzuoli commented 11 months ago

@to24toro I've updated the type hints and added tests for _to_dense and _to_dense_list.

I had to force push as I'm working from my personal laptop and had forgotten to update the git config with my username on commit 7d21240, which triggered the CLA message.