search

qiskit-community / qiskit-dynamics

Tools for building and solving models of quantum systems in Qiskit
https://qiskit-community.github.io/qiskit-dynamics/
Apache License 2.0
103 stars 61 forks source link

Relax pin on Qiskit 1.0 #314

Closed jakelishman closed 7 months ago

jakelishman commented 7 months ago

Summary

This particular pulse test appears to be the only thing that changes in Qiskit 1.0. This commit adds a CI job to test against Qiskit 1.0.0rc1 (which can be removed, or made to target qiskit<1 after 1.0.0 final is released), and relaxes the pin on qiskit.

Details and comments

The new test run will explode right now because of incompatible dependencies, but locally I used a modified version of qiskit-experiments that stubbed out the bits that don't work with Qiskit 1.0, and this passed the test suite for me.

This is presumably on hold til qiskit-experiments is ready.

Admittedly I was running without Jax or diffrax - I assume that's not going to change anything, but I guess we'll see.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

jakelishman commented 7 months ago

A bit of a race condition with Dan - I made this on my side before #312 and #313 were public. I'm fine if this gets closed - the important thing from my side is just that there's a release of qiskit-dynamics with the dependency on qiskit<1 relaxed to simply qiskit (or with a suitable lower bound), and that the package works with Qiskit 1.0.

I added a test to the GitHub CI file that you might want to pinch, but it can't pass in its current form until there's a usable version of qiskit-experiments you can install with qiskit==1.0.0rc1, which the experiments guys are working on.

DanPuzzuoli commented 7 months ago

Thanks for this, but I will close it :) .